qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Review Request 22212: Some more space saving changes for Proton-C
Date Tue, 03 Jun 2014 17:13:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22212/
-----------------------------------------------------------

Review request for qpid, Kenneth Giusti and Rafael Schloming.


Bugs: PROTON-516, PROTON-590 and PROTON-591
    https://issues.apache.org/jira/browse/PROTON-516
    https://issues.apache.org/jira/browse/PROTON-590
    https://issues.apache.org/jira/browse/PROTON-591


Repository: qpid


Description
-------

More changes to save dynamic memory use:
(These changes should save 4k per connection on a regular 64 bit system installation of proton-c).

This is the sum of fixes for PROTON-516, PROTON-591 (and PROTON-590 which is fixed by the
change for PROTON-591).

There are some other small clean ups too (include paths and removing unused #defines)


Diffs
-----

  /proton/trunk/examples/CMakeLists.txt 1598389 
  /proton/trunk/proton-c/CMakeLists.txt 1598389 
  /proton/trunk/proton-c/src/dispatch_actions.h PRE-CREATION 
  /proton/trunk/proton-c/src/dispatcher/dispatcher.h 1598389 
  /proton/trunk/proton-c/src/dispatcher/dispatcher.c 1598389 
  /proton/trunk/proton-c/src/engine/engine-internal.h 1598389 
  /proton/trunk/proton-c/src/sasl/sasl.c 1598389 
  /proton/trunk/proton-c/src/transport/transport.c 1598389 
  /proton/trunk/tests/tools/apps/c/CMakeLists.txt 1598389 

Diff: https://reviews.apache.org/r/22212/diff/


Testing
-------

ctest


Thanks,

Andrew Stitcher


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message