qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chug Rolke" <cro...@redhat.com>
Subject Re: Review Request 22273: In Proton python tests, start subprocesses with Popen(..., shell=os.name=="nt")
Date Thu, 05 Jun 2014 18:14:49 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 5, 2014, 6:14 p.m.)

Review request for qpid and Rafael Schloming.


Upload the diff (I hope!)

Bugs: PROTON-595

Repository: qpid


Popen(file.py, ...) needs to run with shell=True on windows. On Linux the tests hang when
shell=True. This patch compromises by turning on the shell arg when running on windows.

Change the arg list to run Popen(python, file.py, ...) touches wider ranges of source code
with some risk and with no obvious benefit.

Diffs (updated)

  proton/trunk/tests/python/proton_tests/common.py 1600676 

Diff: https://reviews.apache.org/r/22273/diff/


Passes tests on linux and windows.


Chug Rolke

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message