qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request 22582: DISPATCH-56: Replace qpid_dispatch_internal.config with qpid_dispatch_internal.management.
Date Fri, 13 Jun 2014 19:17:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22582/
-----------------------------------------------------------

(Updated June 13, 2014, 7:17 p.m.)


Review request for qpid, Justin Ross and Jason Trost.


Changes
-------

Added diff


Bugs: DISPATCH-56
    https://issues.apache.org/jira/browse/DISPATCH-56


Repository: qpid


Description
-------


    Replace the old config schema with the new management schema.
    - Various error handling improvements.
    - Router code calls out to new config parsing/schema code.
    - Renamed waypoint.name to address, conflict with standard managemenet entity name attribute.
    - Usign new qdrouterd.conf man page, generated from schema.
    - Added references and fixed value attributes to schema.


Diffs (updated)
-----

  dispatch/trunk/doc/man/CMakeLists.txt 1602498 
  dispatch/trunk/doc/man/qdrouterd.conf.5.in 1602498 
  dispatch/trunk/doc/man/qdrouterd_conf_man.py PRE-CREATION 
  dispatch/trunk/doc/man/qdrouterd_man.py 1602498 
  dispatch/trunk/include/qpid/dispatch/config.h 1602498 
  dispatch/trunk/python/qpid_dispatch_internal/config/__init__.py 1602498 
  dispatch/trunk/python/qpid_dispatch_internal/config/parser.py 1602498 
  dispatch/trunk/python/qpid_dispatch_internal/config/schema.py 1602498 
  dispatch/trunk/python/qpid_dispatch_internal/management/__init__.py 1602498 
  dispatch/trunk/python/qpid_dispatch_internal/management/node.py 1602498 
  dispatch/trunk/python/qpid_dispatch_internal/management/qdrouter.json 1602498 
  dispatch/trunk/python/qpid_dispatch_internal/management/qdrouter.py 1602498 
  dispatch/trunk/python/qpid_dispatch_internal/management/schema.py 1602498 
  dispatch/trunk/router/src/main.c 1602498 
  dispatch/trunk/src/config.c 1602498 
  dispatch/trunk/src/config_private.h 1602498 
  dispatch/trunk/src/dispatch.c 1602498 
  dispatch/trunk/src/error.c 1602498 
  dispatch/trunk/src/router_agent.c 1602498 
  dispatch/trunk/src/router_config.c 1602498 
  dispatch/trunk/src/router_node.c 1602498 
  dispatch/trunk/src/router_private.h 1602498 
  dispatch/trunk/src/waypoint.c 1602498 
  dispatch/trunk/tests/management/schema.py 1602498 
  dispatch/trunk/tests/system_tests_broker.py 1602498 
  dispatch/trunk/tests/system_tests_management.py 1602498 
  dispatch/trunk/tests/system_tests_qdstat.py 1602498 
  dispatch/trunk/tests/system_tests_two_routers.py 1602498 

Diff: https://reviews.apache.org/r/22582/diff/


Testing
-------

Passes test.sh


Thanks,

Alan Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message