qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim" <g...@redhat.com>
Subject Re: Review Request 22890: Allow SSL hostname verification to be disabled in c++ client
Date Tue, 24 Jun 2014 07:33:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22890/
-----------------------------------------------------------

(Updated June 24, 2014, 7:33 a.m.)


Review request for qpid, Andrew Stitcher and Pavel Moravec.


Changes
-------

Changes as requested by Andrew.


Repository: qpid


Description
-------

Adds a connection option ignore_ssl_hostname_verification_failure, which if set to true will
cause a connect attempt to proceed even if the hostname connecting to does not match the peers
certificate.


Diffs (updated)
-----

  /trunk/qpid/cpp/src/qpid/client/ConnectionSettings.h 1604917 
  /trunk/qpid/cpp/src/qpid/client/ConnectionSettings.cpp 1604917 
  /trunk/qpid/cpp/src/qpid/client/SslConnector.cpp 1604917 
  /trunk/qpid/cpp/src/qpid/client/amqp0_10/ConnectionImpl.cpp 1604917 
  /trunk/qpid/cpp/src/qpid/messaging/ConnectionOptions.cpp 1604917 
  /trunk/qpid/cpp/src/qpid/messaging/amqp/SslTransport.cpp 1604917 
  /trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.h 1604917 
  /trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.cpp 1604917 

Diff: https://reviews.apache.org/r/22890/diff/


Testing (updated)
-------

make test passes


Thanks,

Gordon Sim


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message