qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ernie Allen" <eal...@redhat.com>
Subject Review Request 22930: Calculate duration in AsyncIO after readCallback
Date Tue, 24 Jun 2014 12:50:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22930/
-----------------------------------------------------------

Review request for qpid, Andrew Stitcher and Gordon Sim.


Repository: qpid


Description
-------

The duration calculation in sys/posix/AsyncIO.cpp readable() was happening before the readCallback()
call. This was allowing the loop to execute for more than the allowable time (as set by threadMaxIoTimeNs).

This patch just changes where the duration is calculated in readable() and writeable(). 


Diffs
-----

  /trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp 1605066 

Diff: https://reviews.apache.org/r/22930/diff/


Testing
-------

Ran reproducer for https://bugzilla.redhat.com/show_bug.cgi?id=977869. The connection delay
dropped by 19%.


Thanks,

Ernie Allen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message