qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chuck Rolke <cro...@redhat.com>
Subject Re: New Defects reported by Coverity Scan for Apache-Qpid
Date Mon, 21 Jul 2014 22:10:08 GMT
Yessir. I think I have a fix in passing with another commit coming up.

-Chuck


----- Original Message -----
> From: "Steve Huston" <shuston@riverace.com>
> To: dev@qpid.apache.org
> Sent: Monday, July 21, 2014 6:05:57 PM
> Subject: RE: Fwd: New Defects reported by Coverity Scan for Apache-Qpid
> 
> Great - thanks Alan!
> 
> Chuck Rolke - is the Acl one maybe something you can check on?
> 
> Thanks,
> -Steve
> 
> > -----Original Message-----
> > From: Alan Conway [mailto:aconway@redhat.com]
> > Sent: Monday, July 21, 2014 12:24 PM
> > To: dev@qpid.apache.org
> > Subject: Re: Fwd: New Defects reported by Coverity Scan for Apache-Qpid
> > 
> > On Mon, 2014-07-21 at 02:36 +0000, Steve Huston wrote:
> > > FYI, folks. Looks like some items to address this week.
> > >
> > > -Steve
> > 
> > Thanks Steve, Waitable.cpp was me - real bug, good catch.
> > >
> > > Begin forwarded message:
> > >
> > > From: <scan-admin@coverity.com<mailto:scan-admin@coverity.com>>
> > > Date: July 20, 2014 at 5:41:51 PM EDT
> > > Subject: New Defects reported by Coverity Scan for Apache-Qpid
> > >
> > >
> > > Hi,
> > >
> > >
> > > Please find the latest report on new defect(s) introduced to Apache-Qpid
> > found with Coverity Scan.
> > >
> > > Defect(s) Reported-by: Coverity Scan
> > > Showing 2 of 2 defect(s)
> > >
> > >
> > > ** CID 1227186:  Mixing enum types  (MIXED_ENUMS)
> > > /qpidbuilds/trunk/qpid/cpp/src/qpid/acl/AclValidator.cpp: 278 in
> > > qpid::acl::AclValidator::registerProperties(const
> > > std::basic_string<char, std::char_traits<char>,
> > > std::allocator<char>>&, qpid::acl::Action, qpid::acl::ObjectType,
> > > const std::basic_string<char, std::char_traits<char>,
> > > std::allocator<char>>&)()
> > >
> > > ** CID 1227187:  Structurally dead code  (UNREACHABLE)
> > > /qpidbuilds/trunk/qpid/cpp/src/qpid/sys/Waitable.h: 99 in
> > > qpid::sys::Waitable::wait(const qpid::sys::AbsTime &)()
> > >
> > >
> > >
> > __________________________________________________________
> > ____________
> > > __________________________________
> > > *** CID 1227186:  Mixing enum types  (MIXED_ENUMS)
> > > /qpidbuilds/trunk/qpid/cpp/src/qpid/acl/AclValidator.cpp: 278 in
> > qpid::acl::AclValidator::registerProperties(const std::basic_string<char,
> > std::char_traits<char>, std::allocator<char>>&, qpid::acl::Action,
> > qpid::acl::ObjectType, const std::basic_string<char,
> > std::char_traits<char>,
> > std::allocator<char>>&)()
> > > 272                     case PROP_MAXFILECOUNT:
> > > 273                         allowedSpecProperties[action][object]-
> > >insert(SPECPROP_MAXFILECOUNTLOWERLIMIT);
> > > 274                         allowedSpecProperties[action][object]-
> > >insert(SPECPROP_MAXFILECOUNTUPPERLIMIT);
> > > 275                         break;
> > > 276                     default:
> > > 277                         // Cases where broker supplies a property and
> > > Acl matches
> > it directly
> > >    CID 1227186:  Mixing enum types  (MIXED_ENUMS)
> > >    Mixing enum types qpid::acl::SpecProperty and qpid::acl::Property for
> > "<temporary>".
> > > 278
> > > allowedSpecProperties[action][object]->insert(
> > SpecProperty(prop) );
> > > 279                         break;
> > > 280                 }
> > > 281             }
> > > 282         }
> > > 283
> > >
> > >
> > __________________________________________________________
> > ____________
> > > __________________________________
> > > *** CID 1227187:  Structurally dead code  (UNREACHABLE)
> > > /qpidbuilds/trunk/qpid/cpp/src/qpid/sys/Waitable.h: 99 in
> > qpid::sys::Waitable::wait(const qpid::sys::AbsTime &)()
> > > 93         }
> > > 94
> > > 95         /** Throws an exception if one is set before or during the
> > > wait. */
> > > 96         bool wait(const AbsTime& absoluteTime) {
> > > 97             exception.raise();
> > > 98             return Monitor::wait(absoluteTime);
> > >    CID 1227187:  Structurally dead code  (UNREACHABLE)
> > >    This code cannot be reached: "this->exception.qpid::sys::...".
> > > 99             exception.raise();
> > > 100         }
> > > 101
> > > 102       private:
> > > 103         size_t waiters;
> > > 104         ExceptionHolder exception;
> > >
> > >
> > >
> > __________________________________________________________
> > ____________
> > > __________________________________
> > > To view the defects in Coverity Scan visit,
> > > http://scan.coverity.com/projects/6?tab=overview
> > >
> > > To unsubscribe from the email notification for new defects,
> > > http://scan5.coverity.com/cgi-bin/unsubscribe.py
> > >
> > >
> > >
> > 
> > 
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org For additional
> > commands, e-mail: dev-help@qpid.apache.org
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
> For additional commands, e-mail: dev-help@qpid.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message