qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Moravec" <pmora...@redhat.com>
Subject Review Request 23231: [C++ client] AMQP 1.0 closing session without closing receiver first marks further messages as redelivered
Date Wed, 02 Jul 2014 13:16:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23231/
-----------------------------------------------------------

Review request for qpid, Andrew Stitcher, Gordon Sim, and mick goulish.


Bugs: QPID-5866
    https://issues.apache.org/jira/browse/QPID-5866


Repository: qpid


Description
-------

Closing a session must release all messages that have yet to be fetched.

Attached is one possible way how to do that: in ConnectionContext::endSession.

The added code is copy&paste from ConnectionContext::detach - isn't it worth having some
inline routine for that?


Diffs
-----

  /trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.cpp 1607260 

Diff: https://reviews.apache.org/r/23231/diff/


Testing
-------

Manual & automated tests passed.


Thanks,

Pavel Moravec


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message