qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cliff Jansen" <cliffjan...@gmail.com>
Subject Re: Review Request 23122: Proton map/hash entries can disappear
Date Wed, 02 Jul 2014 16:18:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23122/
-----------------------------------------------------------

(Updated July 2, 2014, 4:18 p.m.)


Review request for qpid and Rafael Schloming.


Changes
-------

The test case I had wasn't generic (it was based on actual data that would unreliably fail,
depending on heisenburg's mood), so I did not include it in the regression testing.

The first comment gave a clue how to make a generic test in the first place, so that's mostly
what this refresh is about.

The original code is unchanged except fixing the bogus assert (ick).


Bugs: PROTON-617
    https://issues.apache.org/jira/browse/PROTON-617


Repository: qpid


Description
-------

The proposed fix tests for the case of being the first link in a multipart chain and copies
the second entry over top and makes the old location of the second entry available for reuse.


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/object/object.c 1607407 
  http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/tests/object.c 1607407 

Diff: https://reviews.apache.org/r/23122/diff/


Testing
-------


Thanks,

Cliff Jansen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message