qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Review Request 23243: Tidied up a bunch of stuff related to the amqp-0-10 generated code
Date Wed, 02 Jul 2014 19:45:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23243/
-----------------------------------------------------------

Review request for qpid, Alan Conway and Gordon Sim.


Repository: qpid


Description
-------

Currently the ruby code generator generates more code than necessary and there are a whole
bunch of files that are still in the tree that used to support generated code that is no longer
used.

This change just removes the files that are obviously unneeded (by my builds). It also modifies
the generator not to produce lists that cmake doesn't need.

There is more work that could be done I think: The generator can still generate a file for
an autotools build, I expect the generated code could be slimmed down some as well.

This is up for review in case I missed anything obvious.Either that can still be removed,
or that will blow something up that I didn't spot.


Diffs
-----

  trunk/qpid/cpp/rubygen/0-10/allsegmenttypes.rb 1607452 
  trunk/qpid/cpp/rubygen/0-10/exceptions.rb 1607452 
  trunk/qpid/cpp/rubygen/0-10/handlers.rb 1607452 
  trunk/qpid/cpp/rubygen/0-10/specification.rb 1607452 
  trunk/qpid/cpp/rubygen/0-10/typecode.rb 1607452 
  trunk/qpid/cpp/rubygen/generate 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Array.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Array.cpp 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Body.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Codec.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Command.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/CommmandPacker.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Connection.cpp 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Control.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Decimal.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Exception.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/FrameHeader.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/FrameHeader.cpp 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Header.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Header.cpp 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Holder.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Map.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Map.cpp 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Packer.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/SerializableString.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Struct.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Struct32.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Struct32.cpp 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Unit.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/Unit.cpp 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/UnitHandler.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/UnknownStruct.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/UnknownStruct.cpp 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/UnknownType.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/UnknownType.cpp 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/apply.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/built_in_types.h 1607452 
  trunk/qpid/cpp/src/qpid/amqp_0_10/complex_types.cpp 1607452 
  trunk/qpid/cpp/src/qpid/framing/TemplateVisitor.h 1607452 
  trunk/qpid/cpp/src/qpid/framing/Visitor.h 1607452 

Diff: https://reviews.apache.org/r/23243/diff/


Testing
-------

ctest runs to completion.


Thanks,

Andrew Stitcher


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message