qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Evans" <dominic.ev...@uk.ibm.com>
Subject Re: Review Request 23376: [proton][python] Create a setup.py for the python bindings.
Date Thu, 10 Jul 2014 08:39:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23376/#review47557
-----------------------------------------------------------


Couple of minor comments:
* browsing the pypi package list, perhaps the package name should be python-qpid-proton or
pyqpid-proton, having <prefix>-python seemed unusual
* could we have a cmdline option on setup.py to specify the location in which to find libqpid-proton
and the include headers? e.g., ``python setup.py configure --include=/usr/src/qpid-proton-0.7/proton-c/include
--libdir=/usr/src/qpid-proton-0.7/build/proton-c``

- Dominic Evans


On July 9, 2014, 9:07 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23376/
> -----------------------------------------------------------
> 
> (Updated July 9, 2014, 9:07 p.m.)
> 
> 
> Review request for qpid, Gordon Sim, Justin Ross, and Rafael Schloming.
> 
> 
> Bugs: proton-630
>     https://issues.apache.org/jira/browse/proton-630
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> Work in progress - generate a setup.py suitable for package management via Pypi
> 
> At this point, it merely generates the setup.py file into the build directory.  It also
creates a source tarball during install - right now just for a sanity check more than anything.
> 
> Ideally, it would be great to have 'make install' actually do 'python setup.py install'
when SYSINSTALL_BINDINGS is ON, but I haven't gotten that to work yet when CMAKE_INSTALL_PREFIX
isn't in your paths during 'make install'.
> 
> Need to do more testing.
> 
> 
> Diffs
> -----
> 
>   /proton/trunk/proton-c/bindings/python/CMakeLists.txt 1607465 
>   /proton/trunk/proton-c/bindings/python/setup.py.in PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23376/diff/
> 
> 
> Testing
> -------
> 
> tested 'setup.py build/install" by hand.
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message