qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Re: Review Request 23376: [proton][python] Create a setup.py for the python bindings.
Date Thu, 17 Jul 2014 19:36:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23376/
-----------------------------------------------------------

(Updated July 17, 2014, 7:36 p.m.)


Review request for qpid, Andrew Stitcher, Gordon Sim, Justin Ross, and Rafael Schloming.


Changes
-------

Added a huge hard-to-ignore help text that gets printed should setup fail, reminding the user
that the proton development libraries need to be pre-installed.


Bugs: proton-630
    https://issues.apache.org/jira/browse/proton-630


Repository: qpid


Description
-------

Work in progress - generate a setup.py suitable for package management via Pypi

At this point, it merely generates the setup.py file into the build directory.  It also creates
a source tarball during install - right now just for a sanity check more than anything.

Ideally, it would be great to have 'make install' actually do 'python setup.py install' when
SYSINSTALL_BINDINGS is ON, but I haven't gotten that to work yet when CMAKE_INSTALL_PREFIX
isn't in your paths during 'make install'.

Need to do more testing.


Diffs (updated)
-----

  /proton/trunk/proton-c/bindings/python/CMakeLists.txt 1607465 
  /proton/trunk/proton-c/bindings/python/setup.py.in PRE-CREATION 

Diff: https://reviews.apache.org/r/23376/diff/


Testing
-------

tested 'setup.py build/install" by hand.


Thanks,

Kenneth Giusti


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message