qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Godfrey (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (QPID-2969) AMQConnectionFactory is not Serializable
Date Sat, 19 Jul 2014 23:10:38 GMT

    [ https://issues.apache.org/jira/browse/QPID-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067714#comment-14067714
] 

Rob Godfrey edited comment on QPID-2969 at 7/19/14 11:09 PM:
-------------------------------------------------------------

Great work - we should aim to get this in to 0.30

<Edited to remove nonsense due to me not reading the patch properly>

Only comment is that for serializable objects we should probably explicitly set the serialVersionUID
for the class 


was (Author: rgodfrey):
Great work - we should aim to get this in to 0.30

Had a quick look at the patch... my only comment is that I think it might make more sense
for the writeExternal() in AMQDestination to first write a byte to indicate the syntax in
use, then the readExternal can use this identifier to decide how to read the rest of the serialized
object.  In that way the encoding should be truely portable and won't rely on the same state
(default destination syntax) being in use in both the serializing JVM and the deserializing
JVM ....

Also for serializable objects we should probably explicitly set the serialVersionUID for the
class 

> AMQConnectionFactory is not Serializable
> ----------------------------------------
>
>                 Key: QPID-2969
>                 URL: https://issues.apache.org/jira/browse/QPID-2969
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.8
>            Reporter: Gordon Sim
>              Labels: serialization
>         Attachments: 0001-QPID-2969-Make-AMQConnectionFactory-and-AMQDestinati.patch
>
>
> It should be, in order to allow it to be stored in JNDI.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message