qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cliff Jansen" <cliffjan...@gmail.com>
Subject Re: Review Request 24851: Windows SSl: the system lacked sufficient buffer space
Date Thu, 21 Aug 2014 17:49:00 GMT


> On Aug. 21, 2014, 2:20 p.m., Chug Rolke wrote:
> > What was the reproducer to expose this problem? Did it happen rarely or on demand?
I'd be happy to try a reproducer and again with the fixed code to verify.

Thanks Chuck.  See the parent JIRA.  There is a client.cpp attachment and I have a qpid-perftest
command listed that reproduced the problem for me.  The frequency seems to depend on circumstances,
like OS version... perhaps because of driver or other differences that may affect the timing
 of how TCP packets or SSL segments get clumped together or separately.  I tried tests with
fats and slow networks and also inserting fake delays in the AsynchIO layer.


- Cliff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24851/#review51175
-----------------------------------------------------------


On Aug. 19, 2014, 3:01 p.m., Cliff Jansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24851/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 3:01 p.m.)
> 
> 
> Review request for qpid, Andrew Stitcher and Steve Huston.
> 
> 
> Bugs: QPID-5033
>     https://issues.apache.org/jira/browse/QPID-5033
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> This patch isolates the logic of using the correct amount of buffers and not hanging
onto an unread buffer unless it actually is one.  It has been heavily tested on Linux and
only been lightly tested on Windows.  See patch #2 for the better windows version.
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/AsynchIO.h 1618723

>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp
1618723 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/AsynchIO.h
PRE-CREATION 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/AsynchIO.cpp
1618723 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/SslAsynchIO.cpp
1618723 
> 
> Diff: https://reviews.apache.org/r/24851/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cliff Jansen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message