qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chug Rolke" <cro...@redhat.com>
Subject Re: Review Request 24851: Windows SSl: the system lacked sufficient buffer space
Date Fri, 22 Aug 2014 15:27:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24851/#review51290
-----------------------------------------------------------

Ship it!


I ran these tests before and after this patch:
`
WINDOW 1 - setup, control
>qpid-perftest.exe                -b host.example.com -P ssl -p 5671 --setup
WINDOW 2 - publish
>qpid-perftest.exe --count 100000 -b host.example.com -P ssl -p 5671 --publish
WINDOW 3 - subscribe
>qpid-perftest.exe --count 100000 -b host.example.com -P ssl -p 5671 --subscribe --log-enable
debug+
WINDOW 1 - setup, control
>qpid-perftest.exe                -b host.example.com -P ssl -p 5671 --setup
`
Before the patch the test fails with ssl error five times in a row.
After the patch the test passes five times in a row.

- Chug Rolke


On Aug. 19, 2014, 3:01 p.m., Cliff Jansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24851/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 3:01 p.m.)
> 
> 
> Review request for qpid, Andrew Stitcher and Steve Huston.
> 
> 
> Bugs: QPID-5033
>     https://issues.apache.org/jira/browse/QPID-5033
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> This patch isolates the logic of using the correct amount of buffers and not hanging
onto an unread buffer unless it actually is one.  It has been heavily tested on Linux and
only been lightly tested on Windows.  See patch #2 for the better windows version.
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/AsynchIO.h 1618723

>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp
1618723 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/AsynchIO.h
PRE-CREATION 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/AsynchIO.cpp
1618723 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/SslAsynchIO.cpp
1618723 
> 
> Diff: https://reviews.apache.org/r/24851/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cliff Jansen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message