qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Re: Review Request 25101: Minimal fix for broken ssl over AMQP 1.0
Date Wed, 27 Aug 2014 17:12:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25101/#review51663
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Stitcher


On Aug. 27, 2014, 4:01 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25101/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 4:01 p.m.)
> 
> 
> Review request for qpid and Andrew Stitcher.
> 
> 
> Bugs: QPID-6049
>     https://issues.apache.org/jira/browse/QPID-6049
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> The change for https://issues.apache.org/jira/browse/QPID-5788 prevents NSS being initialised
for AMQP 1.0 based ssl connections. This is a minimal fix for the 0.30 release that avoids
too much change in order to reduce the risk of some unintended consequence sneaking in. The
ideal solution I think is to push some of the logic currently in SslConnector.cpp up in to
sys/ssl/util.cpp.
> 
> All this change really does is expose the ability to lazily initialise NSS from outside
SslConnector.cpp and uses that from the SslTransport for the AMQP 1.0 path.
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/cpp/src/qpid/client/SslConnector.cpp 1620630 
>   trunk/qpid/cpp/src/qpid/client/ssl.h PRE-CREATION 
>   trunk/qpid/cpp/src/qpid/messaging/amqp/SslTransport.cpp 1620630 
>   trunk/qpid/cpp/src/tests/ssl_test 1620630 
> 
> Diff: https://reviews.apache.org/r/25101/diff/
> 
> 
> Testing
> -------
> 
> Added an AMQP 1.0 based test for ssl. Ran make test.
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message