qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Moravec" <pmora...@redhat.com>
Subject Re: Review Request 25938: qpid-stat -u to show Outgoing objects for AMQP 1.0
Date Wed, 24 Sep 2014 14:34:08 GMT


> On Sept. 23, 2014, 1:21 p.m., Gordon Sim wrote:
> > Does this work if 1.0 is not supported?
> > 
> > My initial instinct I think would be to populate a qmf::org::apache::qpid::broker::Subscription
object for the outgoing link, rather than doing it in the tool.

If broker does not load amqp.so / does not support AMQP 1.0, then qpid-stat just queries for
all outgoing objects and gets empty list from the broker (checked via tcpdump). No issue detected
during this test.

To populate Subscription object: that would require having Subscription and Outgoing objects
in sync (esp.delivered/transfers counter) - would be that acceptable?


- Pavel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25938/#review54267
-----------------------------------------------------------


On Sept. 23, 2014, 12:48 p.m., Pavel Moravec wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25938/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2014, 12:48 p.m.)
> 
> 
> Review request for qpid, Ernie Allen and Gordon Sim.
> 
> 
> Bugs: QPID-6113
>     https://issues.apache.org/jira/browse/QPID-6113
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> A straightforward extension of "qpid-stat -u" to include AMQP 1.0 Outgoing objects to
have all consumers of queues in one output.
> 
> Some minor questions/issues:
> 
> - columns "browsing", "acknowledged" and "exclusive" would remain False everytime for
Outgoging objects, as these attributes are irrelevant or QMF object Outgoing does not track
it
> - credit mode is not tracked in Outgoing object as well, as that string is filled everytime,
I suggest to have there AMQP1.0 or anything similar - this allows to distinguish Subscriptions
from outgoings as well
> 
> I could extend Outgoing QMF object to cover e.g. browsing or creditMode Subscription
property also in Outgoing, I am just not sure how much beneficial it would be.
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/tools/src/py/qpid-stat 1626808 
>   trunk/qpid/tools/src/py/qpidtoollibs/broker.py 1626808 
> 
> Diff: https://reviews.apache.org/r/25938/diff/
> 
> 
> Testing
> -------
> 
> Example output:
> 
> 
>     ./tools/src/py/qpid-stat -u
>     Subscriptions and Outgoings
>       subscr                                  queue                                 
   conn                                 procName      procId  browse  acked  excl  creditMode
 delivered  sessUnacked
>       ======================================================================================================================================================================================================
>       0                                       620f2fc9-9b4d-4593-858e-5b13347c2657:0.0
 qpid.[::1]:5672-[::1]:52684          qpid-stat     768                          CREDIT  
   0          0
>       q                                       q                                     
   qpid.127.0.0.1:5672-127.0.0.1:46453  qpid-receive  517             Y            WINDOW
     0          0
>       q_3114e33b-dd76-491b-8f9c-0b4d50bcd24d  q                                     
   qpid.127.0.0.1:5672-127.0.0.1:46623  qpid-receive  710                          AMQP1.0
    0          0
> 
> 
> Thanks,
> 
> Pavel Moravec
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message