qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Moravec (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (QPID-6118) Add qmf shutdown command to the broker
Date Fri, 26 Sep 2014 13:07:34 GMT

     [ https://issues.apache.org/jira/browse/QPID-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Pavel Moravec updated QPID-6118:
--------------------------------
    Attachment: QPID-6118-inspiration.patch

Inspiration for final patch, including ACLs.

Attached patch works well, just:
- the caller of "shutdown" QMF command does not get response as the broker shuts down before
responding. Not sure if desired/acceptable behaviour.
- the broker reacts by calling Broker::shutdown method only. Not sure what else to call/cleanup/..
when processing the QMF request

Some testing:
(*) without ACLs preventing shutdown (shutdown_broker is trivial program that just calls QMF
shutdown method against broker object):
$ ./shutdown_broker
2014-09-26 15:05:39 [Client] warning Connection [127.0.0.1:35530-127.0.0.1:5672] closed
Failed to connect (reconnect disabled)
$
(broker traces show normal shutdown)

(*) with ACLs preventing shutdown:
$ cat ~/.qpidd/qpidd.acl
acl deny all shutdown broker
acl allow all all
$ ./shutdown_broker 
fetching response with timeout 1000ms.
Error: �_values��
error_code"
error_text�xunauthorized-access: ACL denied broker shutdown from anonymous@QPID (/data_xfs/qpid/cpp/src/qpid/broker/Broker.cpp:1305)
$

> Add qmf shutdown command to the broker 
> ---------------------------------------
>
>                 Key: QPID-6118
>                 URL: https://issues.apache.org/jira/browse/QPID-6118
>             Project: Qpid
>          Issue Type: Improvement
>          Components: C++ Broker
>    Affects Versions: 0.28
>            Reporter: Alan Conway
>            Assignee: Alan Conway
>         Attachments: QPID-6118-inspiration.patch
>
>
> Add a QMF shutdown command to the broker. On receiving this command the broker would
shut down in the same way as if it received a kill -TERM.
> The shutdown command must be restriced by a new ACL rule for security purposes.
> Discussed on the qpid user list, all responses to the idea were positive:
> http://qpid.2158936.n2.nabble.com/QPID-C-Dynamically-Managing-Broker-td7613792.html#a7614175



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message