qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rafael H. Schloming (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-6123) [C++ Messaging] Build fail - proton no longer exports pn_transport_error()
Date Fri, 26 Sep 2014 13:48:35 GMT

    [ https://issues.apache.org/jira/browse/QPID-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149154#comment-14149154
] 

Rafael H. Schloming commented on QPID-6123:
-------------------------------------------

It's not hard to provide backwards compatibility here. I just didn't know if it was necessary.
Go ahead and file a proton JIRA and mark it for 0.8 if it will make things easier.

> [C++ Messaging] Build fail - proton no longer exports pn_transport_error()
> --------------------------------------------------------------------------
>
>                 Key: QPID-6123
>                 URL: https://issues.apache.org/jira/browse/QPID-6123
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Client
>    Affects Versions: 0.28
>         Environment: All
>            Reporter: Chuck Rolke
>
> Commit r1627444 changes the proton transport error interface. See http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/include/proton/transport.h?r1=1627444&r2=1627443&pathrev=1627444
> The build failure is:
> {noformat}
> 18>..\..\src\qpid\messaging\amqp\ConnectionContext.cpp(811) : 
>   error C3861: 'pn_transport_error': identifier not found
> {noformat}
> Rafi explains on the mailing list:
> {panel}
> I removed it because a previous commit had changed it to just return NULL.
> I figured it would be better to break things than to fail silently. If this
> is a problem I can add easily it back and convert what is held in the
> condition into the error, but using the condition would be preferrable as
> it can contain the full range of AMQP error information whereas the error
> will just have a string description.
> --Rafael
> {panel}
> Which is fine but qpid won't build until we figure out how to deal with it.
> Further, this change is a painful complication to the proton 0.7 to 0.8 transition. Possibly
we can restore pn_transport_error() to keep returning the error string but mark it as deprecated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message