qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Re: Review Request 27734: Add safe version of QPID_LOG macro
Date Fri, 07 Nov 2014 18:10:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27734/#review60354
-----------------------------------------------------------



trunk/qpid/cpp/src/qpid/log/Statement.h
<https://reviews.apache.org/r/27734/#comment101716>

    It might be better to investigate a little bit more what can cause QPID_LOG to throw an
exception and to mitigate it or catch it closer to the source.


- Andrew Stitcher


On Nov. 7, 2014, 6:06 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27734/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 6:06 p.m.)
> 
> 
> Review request for qpid, Alan Conway, Andrew Stitcher, and Steve Huston.
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> For use in contexts where exceptions cannot be thrown, add a wrapped version of QPID_LOG
that catches any exception.
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/cpp/src/qpid/broker/DtxAck.cpp 1637402 
>   trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1637402 
>   trunk/qpid/cpp/src/qpid/broker/TxAccept.cpp 1637402 
>   trunk/qpid/cpp/src/qpid/broker/TxDequeue.cpp 1637402 
>   trunk/qpid/cpp/src/qpid/log/Statement.h 1637402 
> 
> Diff: https://reviews.apache.org/r/27734/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message