qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim" <g...@redhat.com>
Subject Re: Review Request 28770: Some engine examples and supporting library code
Date Mon, 08 Dec 2014 11:44:10 GMT


> On Dec. 5, 2014, 10:13 p.m., Rafael Schloming wrote:
> > proton-c/bindings/python/proton/__init__.py, line 3488
> > <https://reviews.apache.org/r/28770/diff/1/?file=784021#file784021line3488>
> >
> >     Isn't there some redundancy here? For example this hasattr check is redudant
with the clazz == "pn_session" case above.
> >     
> >     Presumably if you were to define the appropriate attributes (e.g. define Delivery.connection,
Link.connection, etc) all of these properties would become redundant with the generic __getattr__
that you've added below this.
> >     
> >     I'm not sure I'm a fan of just splatting all the context properties into the
event, but if you're going to do that then I would be consistent about it and remove all of
these as they are essentially redundant now.

Yes, I could add properties to Delivery (Link already has one). I'd still need a test for
when the context was itself a Connection, of course, but I agree it would be cleaner overall.
I'll make that change.


- Gordon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28770/#review64091
-----------------------------------------------------------


On Dec. 5, 2014, 8:55 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28770/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 8:55 p.m.)
> 
> 
> Review request for qpid and Rafael Schloming.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> These are the current reactive examples using the engine API, that I have been evolving
on the examples branch, alog with the utility code they depend on. I still need to evolve/rationalise
the examples themselves as well as the utility code, but I believe it would be beneficial
to all to do this from the master branch.
> 
> 
> Diffs
> -----
> 
>   examples/engine/py/abstract_server.py PRE-CREATION 
>   examples/engine/py/client.py PRE-CREATION 
>   examples/engine/py/client_http.py PRE-CREATION 
>   examples/engine/py/common.py PRE-CREATION 
>   examples/engine/py/db_common.py PRE-CREATION 
>   examples/engine/py/db_ctrl.py PRE-CREATION 
>   examples/engine/py/db_recv.py PRE-CREATION 
>   examples/engine/py/db_send.py PRE-CREATION 
>   examples/engine/py/helloworld.py PRE-CREATION 
>   examples/engine/py/helloworld_blocking.py PRE-CREATION 
>   examples/engine/py/helloworld_direct.py PRE-CREATION 
>   examples/engine/py/helloworld_direct_tornado.py PRE-CREATION 
>   examples/engine/py/helloworld_tornado.py PRE-CREATION 
>   examples/engine/py/proton_server.py PRE-CREATION 
>   examples/engine/py/proton_tornado.py PRE-CREATION 
>   examples/engine/py/recurring_timer.py PRE-CREATION 
>   examples/engine/py/recurring_timer_tornado.py PRE-CREATION 
>   examples/engine/py/selected_recv.py PRE-CREATION 
>   examples/engine/py/server.py PRE-CREATION 
>   examples/engine/py/server_tx.py PRE-CREATION 
>   examples/engine/py/simple_recv.py PRE-CREATION 
>   examples/engine/py/simple_send.py PRE-CREATION 
>   examples/engine/py/sync_client.py PRE-CREATION 
>   examples/engine/py/tx_recv.py PRE-CREATION 
>   examples/engine/py/tx_recv_interactive.py PRE-CREATION 
>   examples/engine/py/tx_send.py PRE-CREATION 
>   examples/engine/py/tx_send_sync.py PRE-CREATION 
>   proton-c/bindings/python/CMakeLists.txt 6be421e237f86f2aa99c23ffbc08af821b5c8438 
>   proton-c/bindings/python/proton/__init__.py fce3255bfce440dcae57457d259147a4ced8216e

>   proton-c/bindings/python/proton/handlers.py PRE-CREATION 
>   proton-c/bindings/python/proton/reactors.py PRE-CREATION 
>   proton-c/bindings/python/proton/utils.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28770/diff/
> 
> 
> Testing
> -------
> 
> All examples have been tested, note that the transactional examples require a couple
of extra proton-c patches (available on respective JIRAs) in order to run correctly.
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message