qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rafael Schloming" <...@apache.org>
Subject Re: Review Request 28928: Eliminate pn_dispatcher_t and move its state and functionality to pn_transport_t
Date Fri, 12 Dec 2014 04:48:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28928/#review64864
-----------------------------------------------------------

Ship it!


Ship It!

- Rafael Schloming


On Dec. 11, 2014, 4:44 a.m., Andrew Stitcher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28928/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 4:44 a.m.)
> 
> 
> Review request for qpid and Rafael Schloming.
> 
> 
> Bugs: PROTON-770
>     https://issues.apache.org/jira/browse/PROTON-770
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> See PROTON-770 for description
> 
> This change is the first in a proposed refactor of the transport to eliminate redundent
buffering and copying and to restructure some of the protocol control flow when dealing with
multiple protocol layers.
> 
> See my repo on github for the diff in context:
> https://github.com/astitcher/qpid-proton/commits/transport-refactoring
> 
> The same change but broken down into smaller commits
> https://github.com/astitcher/qpid-proton/commits/transport-refactoring-details
> 
> Github pull request:
> https://github.com/apache/qpid-proton/pull/
> 
> 
> Diffs
> -----
> 
>   proton-c/src/dispatcher/dispatcher.h b9bfa2bafedccea72221c04ab34c4a2ced254d78 
>   proton-c/src/dispatcher/dispatcher.c 3b96a678c25901504d7146f4ae9d717b3afcd128 
>   proton-c/src/engine/engine-internal.h 4ee9a694ad2b25383c51dff094ac00e8f29bab37 
>   proton-c/src/sasl/sasl.c 5a174e26b87c9fcb04478f173c6e15b80cfa4ba1 
>   proton-c/src/transport/transport.c 097d8632d428fd69e0193101527a249eeca5601c 
> 
> Diff: https://reviews.apache.org/r/28928/diff/
> 
> 
> Testing
> -------
> 
> Passes ctest on Linux and Windows.
> 
> (the ruby tests are failing for me, but this is not related to this change as far as
I can tell)
> 
> 
> Thanks,
> 
> Andrew Stitcher
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message