qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-6252) AMQP 1.0 browsing client generates large number of errors on broker.
Date Fri, 05 Dec 2014 13:40:12 GMT

    [ https://issues.apache.org/jira/browse/QPID-6252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235478#comment-14235478
] 

ASF subversion and git services commented on QPID-6252:
-------------------------------------------------------

Commit 1643276 from [~aconway] in branch 'qpid/trunk'
[ https://svn.apache.org/r1643276 ]

QPID-6252: AMQP 1.0 browsing client generates large number of errors on broker (better fix)

This is a simpler and better fix based on the discussion at:

http://qpid.2158936.n2.nabble.com/Re-svn-commit-r1642720-in-qpid-trunk-qpid-cpp-src-qpid-messaging-amqp-AddressHelper-h-ConnectionConth-td7617083.html

The changes are all client-side:
- A browsing address is unreliable by default. An explicit reliability setting is respected.
- The client session does not record pre-settled deliveries in it's unacked list.

So by default:
- Browsing links are unreliable. Broker sends pre-settled, messages are not recorded in unacked
list.
- The user is not required to acknowledge browsed messages for proper clean-up.
- Calling acknowledge() for a browsed message is a no-op, not an error.

If the user explicitly requests a reliable browsing link, then we behave exactly as before.
I can't see any value in doing this with qpidd but maybe with some other broker there might
be
a use for being able to control the accept of browsed messages.

This does affect non-browsing, unreliable links but it is an improvement.
Settling a pre-settled messages is a no-op, so there is no point in recording
pre-settled messages in the unacked list since we do nothing when they are
acknoweldged.

> AMQP 1.0 browsing client generates large number of errors on broker.
> --------------------------------------------------------------------
>
>                 Key: QPID-6252
>                 URL: https://issues.apache.org/jira/browse/QPID-6252
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Client
>    Affects Versions: 0.31
>            Reporter: Alan Conway
>            Assignee: Alan Conway
>             Fix For: 0.31
>
>
>  An AMQP 1.0 client that uses a mixtiure of browsing and acquiring receivers on the same
session generates spurious error messages in the broker log like this:
> [Broker] error Delivery returned for unknown link
> The following python program illustrates the problem.
> {noformat}
> from qpid_messaging import *
> c = Connection.establish("localhost", protocol="amqp1.0")
> ssn = c.session()
> ssn.sender("foo;{create:always}").send("foo")
> r = ssn.receiver("foo;{mode:browse}")
> r.fetch().content
> r.close()
> ssn.acknowledge()
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message