qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-88) Python functions invoked without the Python lock being held causes crash
Date Wed, 17 Dec 2014 16:46:13 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250099#comment-14250099
] 

ASF subversion and git services commented on DISPATCH-88:
---------------------------------------------------------

Commit 1646292 from [~tedross] in branch 'dispatch/trunk'
[ https://svn.apache.org/r1646292 ]

DISPATCH-88 - Added asserts to check the python lock.  Fixed instance of python calls with
the lock not held.

> Python functions invoked without the Python lock being held causes crash
> ------------------------------------------------------------------------
>
>                 Key: DISPATCH-88
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-88
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Container
>            Reporter: Ted Ross
>            Assignee: Ted Ross
>            Priority: Blocker
>             Fix For: 0.3
>
>
> There is at least one case of the invocation of Python extension APIs in a thread-unsafe
way (i.e. the python lock is not held).  This occurs in router_pynode.c on line 641.
> {noformat}
>     if (pyTick && router->router_mode == QD_ROUTER_MODE_INTERIOR) {
>         qd_python_lock_state_t lock_state = qd_python_lock();
>         pArgs  = PyTuple_New(0);
>         pValue = PyObject_CallObject(pyTick, pArgs);
>         Py_DECREF(pArgs);
>         Py_XDECREF(pValue);
>         qd_python_unlock(lock_state);
>     }
>     return qd_error_py();
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message