qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim" <g...@redhat.com>
Subject Review Request 29636: Allow transaction state of incoming transfers to be read
Date Tue, 06 Jan 2015 20:51:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29636/
-----------------------------------------------------------

Review request for qpid, Alan Conway and Rafael Schloming.


Bugs: PROTON-730
    https://issues.apache.org/jira/browse/PROTON-730


Repository: qpid-proton-git


Description
-------

At present, there is no way to get at the extra state information that may be part of a transfer
received.

This fix follows the same approach already in place for dispositions, whereby the descriptor
code is available via pn_delivery_remote_state(). However this approach does seem limited
to cases (admittedly the most likely) where the descriptor is numeric. Assuming it is valid
to send a symbolic descriptor for delivery states, proton-c wouldn't read them.


Diffs
-----

  proton-c/src/transport/transport.c a434b4854ba482de01efa85bfc0e29a22e8f5cbc 

Diff: https://reviews.apache.org/r/29636/diff/


Testing
-------

make test passes


Thanks,

Gordon Sim


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message