qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request 29636: Allow transaction state of incoming transfers to be read
Date Wed, 07 Jan 2015 18:49:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29636/#review67055
-----------------------------------------------------------

Ship it!


Ship It!

- Alan Conway


On Jan. 6, 2015, 8:51 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29636/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 8:51 p.m.)
> 
> 
> Review request for qpid, Alan Conway and Rafael Schloming.
> 
> 
> Bugs: PROTON-730
>     https://issues.apache.org/jira/browse/PROTON-730
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> At present, there is no way to get at the extra state information that may be part of
a transfer received.
> 
> This fix follows the same approach already in place for dispositions, whereby the descriptor
code is available via pn_delivery_remote_state(). However this approach does seem limited
to cases (admittedly the most likely) where the descriptor is numeric. Assuming it is valid
to send a symbolic descriptor for delivery states, proton-c wouldn't read them.
> 
> 
> Diffs
> -----
> 
>   proton-c/src/transport/transport.c a434b4854ba482de01efa85bfc0e29a22e8f5cbc 
> 
> Diff: https://reviews.apache.org/r/29636/diff/
> 
> 
> Testing
> -------
> 
> make test passes
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message