qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim" <g...@redhat.com>
Subject Re: Review Request 29680: Long-lived messaging clients never free proton sender and receiver links
Date Wed, 07 Jan 2015 23:01:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29680/#review67115
-----------------------------------------------------------

Ship it!


Looks good to me! HA tests always pass for me btw, so possibly something in your environment.

- Gordon Sim


On Jan. 7, 2015, 10:45 p.m., Chug Rolke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29680/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2015, 10:45 p.m.)
> 
> 
> Review request for qpid and Gordon Sim.
> 
> 
> Bugs: QPID-6298
>     https://issues.apache.org/jira/browse/QPID-6298
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> Messaging example server.cpp creates a sender for each message it receives in order to
reply to the request's originator. After the sender is deleted it is never freed and the server's
memory usage grows unbounded.
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/cpp/src/qpid/messaging/amqp/ReceiverContext.cpp 1649611 
>   trunk/qpid/cpp/src/qpid/messaging/amqp/SenderContext.cpp 1649611 
> 
> Diff: https://reviews.apache.org/r/29680/diff/
> 
> 
> Testing
> -------
> 
> Passes normal self tests (except HA that 'never' passes).
> 
> Testing needs to be done to find the oldest version of proton on which this patch works.
Then that proton version needs to be set as the minimum required.
> 
> 
> Thanks,
> 
> Chug Rolke
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message