qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gordon Sim <g...@redhat.com>
Subject Re: API change? (was Re: [1/3] qpid-proton git commit: alias pn_delivery_tag_t to pn_bytes_t)
Date Fri, 16 Jan 2015 18:45:21 GMT
On 01/16/2015 06:36 PM, Rafael Schloming wrote:
> On Fri, Jan 16, 2015 at 12:53 PM, Gordon Sim <gsim@redhat.com> wrote:
>
>> On 01/13/2015 09:26 PM, rhs@apache.org wrote:
>>
>>> Repository: qpid-proton
>>> Updated Branches:
>>>     refs/heads/master fc66f4c44 -> 99df0a33d
>>>
>>>
>>> alias pn_delivery_tag_t to pn_bytes_t
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/
>>> 081336f2
>>> Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/081336f2
>>> Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/081336f2
>>>
>>> Branch: refs/heads/master
>>> Commit: 081336f24c62253d2ea702ffb43235a2afa75771
>>> Parents: fc66f4c
>>> Author: Rafael Schloming <rhs@alum.mit.edu>
>>> Authored: Tue Jan 13 14:23:22 2015 -0500
>>> Committer: Rafael Schloming <rhs@alum.mit.edu>
>>> Committed: Tue Jan 13 14:27:35 2015 -0500
>>>
>>
>> [...]
>>
>> The change below breaks the API, is that deliberate? It will affect at
>> least qpid-cpp (possibly also dispatch).
>>
>
> It was deliberate, although I didn't spend overly long considering the
> consequences, so if it's a problem we can roll it back.
>
> FWIW, I think the change preserves binary compatibility, however the struct
> fields are (unfortunately) named slightly differently.

I can change qpid-cpp to handle the difference, if that is the only 
thing that is affected. Dispatch appears not to have an issue.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message