qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rafael Schloming" <...@apache.org>
Subject Re: Review Request 30379: Skeleton code for a possible approach for codec improvements in proton-j.
Date Mon, 02 Feb 2015 21:41:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30379/#review70627
-----------------------------------------------------------



proton-j/src/main/java/org/apache/qpid/proton/amqp/transport2/Flow.java
<https://reviews.apache.org/r/30379/#comment115893>

    I'm not sure we should do this kind of validation here. This is really a semantic check,
I would stick to just syntactic checks in the decode, e.g. if you get a String where you expect
an int or something like that.
    
    I would put the sort of semantic check you have here in a separate method since it would
be useful to be able to a) omit it at runtime for performance reasons, and b) it would also
be useful to perform the same validation prior to encoding.



proton-j/src/main/java/org/apache/qpid/proton/codec2/POJOBuilder.java
<https://reviews.apache.org/r/30379/#comment115889>

    This should probably be moved out into a top level class, I think I just had it nested
for conciseness.



proton-j/src/main/java/org/apache/qpid/proton/codec2/PerformativeFactory.java
<https://reviews.apache.org/r/30379/#comment115887>

    PerformativeFactory is a bit over specific for the name of this. It can really work on
any described type and we will need to use it for things nested inside of performatives also
(like error conditions, etc). Maybe DescribedFactory?



proton-j/src/main/java/org/apache/qpid/proton/codec2/TypeRegistry.java
<https://reviews.apache.org/r/30379/#comment115886>

    DescriptorRegistry might be a bit more precise as a name for this


- Rafael Schloming


On Feb. 2, 2015, 6:38 p.m., rajith attapattu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30379/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2015, 6:38 p.m.)
> 
> 
> Review request for qpid and Rafael Schloming.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> Skeleton code for a possible approach for codec improvements in proton-j.
> 
> 
> Diffs
> -----
> 
>   proton-j/src/main/java/org/apache/qpid/proton/amqp/transport2/Flow.java 388cbef 
>   proton-j/src/main/java/org/apache/qpid/proton/codec2/DecodeException.java PRE-CREATION

>   proton-j/src/main/java/org/apache/qpid/proton/codec2/Decoder.java d61fdef 
>   proton-j/src/main/java/org/apache/qpid/proton/codec2/Encodable.java PRE-CREATION 
>   proton-j/src/main/java/org/apache/qpid/proton/codec2/POJOBuilder.java c95844b 
>   proton-j/src/main/java/org/apache/qpid/proton/codec2/PerformativeFactory.java PRE-CREATION

>   proton-j/src/main/java/org/apache/qpid/proton/codec2/TransportTypesDecoder.java a262760

>   proton-j/src/main/java/org/apache/qpid/proton/codec2/TransportTypesEncoder.java c7c888c

>   proton-j/src/main/java/org/apache/qpid/proton/codec2/TypeRegistry.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/30379/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> rajith attapattu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message