qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Re: Review Request 30526: DISPATCH-109: add parsing of subject field
Date Thu, 05 Feb 2015 19:02:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30526/#review71272
-----------------------------------------------------------



trunk/src/message.c
<https://reviews.apache.org/r/30526/#comment116946>

    Field may be parsed && NULL
    
    Also, "Conway" this code.


- Kenneth Giusti


On Feb. 5, 2015, 5:20 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30526/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 5:20 p.m.)
> 
> 
> Review request for qpid, Alan Conway, Ernie Allen, michael goulish, and Ted Ross.
> 
> 
> Bugs: DISPATCH-109
>     https://issues.apache.org/jira/browse/DISPATCH-109
> 
> 
> Repository: qpid-dispatch
> 
> 
> Description
> -------
> 
> Refactor the field parse logic.  Avoid re-parsing fields previous to the target field.
 My understanding of the existing field parsing code may be a littled flawed - please let
me know if you see anything that doesn't make sense or seems sub-optimal.
> 
> 
> Diffs
> -----
> 
>   trunk/include/qpid/dispatch/message.h 1656496 
>   trunk/src/message.c 1656496 
>   trunk/src/message_private.h 1656496 
>   trunk/tests/message_test.c 1656496 
> 
> Diff: https://reviews.apache.org/r/30526/diff/
> 
> 
> Testing
> -------
> 
> Added a new unit test.
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message