qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Justin Ross" <jr...@apache.org>
Subject Re: Review Request 30640: Provide a means to invoke a callback when a message has arrived.
Date Wed, 11 Feb 2015 14:13:21 GMT


> On Feb. 11, 2015, 2:05 p.m., Justin Ross wrote:
> > trunk/qpid/python/qpid/messaging/endpoints.py, line 694
> > <https://reviews.apache.org/r/30640/diff/1/?file=848933#file848933line694>
> >
> >     on_message looks like something you should subclass and override, which I don't
think is what you intend.  This is more like "set the message receive handler" -> set_message_receive_handler(handler)?

Sorry, that should be message_receive*d* handler to match the event.


- Justin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30640/#review71962
-----------------------------------------------------------


On Feb. 4, 2015, 10:31 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30640/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 10:31 p.m.)
> 
> 
> Review request for qpid, Gordon Sim and Justin Ross.
> 
> 
> Bugs: QPID-5799
>     https://issues.apache.org/jira/browse/QPID-5799
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> The patch provides an API to supply a callback that gets invoked when a message has arrived
on a session.  This callback can be used to signal the application thread that a message is
ready for processing.
> 
> This patch will address QPID-5799 by giving the user the ability to wake up their application
thread that is waiting in an epoll loop.  In this case the callback will simply write to a
socket that is being monitored by the epoll loop.
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/python/qpid/messaging/driver.py 1657134 
>   trunk/qpid/python/qpid/messaging/endpoints.py 1657134 
>   trunk/qpid/python/qpid/tests/messaging/endpoints.py 1657134 
> 
> Diff: https://reviews.apache.org/r/30640/diff/
> 
> 
> Testing
> -------
> 
> Added a specific test case.
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message