qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request 31681: suggestion: rename proton.utils to proton.sync?
Date Tue, 03 Mar 2015 23:01:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31681/#review75072
-----------------------------------------------------------


I agree with the name change but please don't break dispatch at this late date. Please add
a utils.py with `from sync import *` for backwards compatibility, put a comment in there to
say don't use it, deprecated, internal use only, beware of dragons etc.  Maybe build dispatch
against it just to be sure ;)

- Alan Conway


On March 3, 2015, 2:39 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31681/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 2:39 p.m.)
> 
> 
> Review request for qpid, Alan Conway, Justin Ross, and Rafael Schloming.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> In order to convey a little bit more about what the contents do. Just a suggestion.
> 
> 
> Diffs
> -----
> 
>   examples/python/helloworld_blocking.py d9a24a9 
>   examples/python/sync_client.py 82cd85f 
>   proton-c/bindings/python/CMakeLists.txt 7f54033 
>   proton-c/bindings/python/proton/sync.py PRE-CREATION 
>   proton-c/bindings/python/proton/utils.py d5e2e0a 
>   tests/python/proton_tests/sync.py PRE-CREATION 
>   tests/python/proton_tests/utils.py 727b586 
> 
> Diff: https://reviews.apache.org/r/31681/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message