qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-6469) Improve AMQProtocolEngine#exception to guard against an exception whilst trying to send response to client from the method
Date Thu, 02 Apr 2015 16:30:52 GMT

    [ https://issues.apache.org/jira/browse/QPID-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392914#comment-14392914
] 

ASF subversion and git services commented on QPID-6469:
-------------------------------------------------------

Commit 1670933 from orudyy@apache.org in branch 'qpid/trunk'
[ https://svn.apache.org/r1670933 ]

QPID-6469: Remove not used method sendResponseAndCloseSender from AMQProtocolEngine.
           Remove exception handling code from ProtocolEngine_1_0_0_SASL as it is not used
by new i/o layer

> Improve AMQProtocolEngine#exception to guard against an exception whilst trying to send
response to client from the method
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-6469
>                 URL: https://issues.apache.org/jira/browse/QPID-6469
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.18, 0.19, 0.20, 0.21, 0.22, 0.23, 0.24, 0.25, 0.26, 0.27, 0.28,
0.29, 0.30, 0.32
>            Reporter: Alex Rudyy
>            Assignee: Alex Rudyy
>
> If an exception occurs whilst processing AMQProtocolEngine#exception this is caught by
the uncaught exception handler and this causes the Broker to exit.  Failures to close the
connection should be logged and ignored.  
> This stacktrace below demonstrates the issue.  It is possible in this case transaction
timeout had cause the connection closed at the same point that the client tried to perform
a command.
> {noformat}
> 2015-03-16 00:27:33,370 ERROR [IoReceiver - /169.115.199.62:50130] thread.LoggingUncaughtExceptionHandler
(LoggingUncaughtExceptionHandler.java:51) - Uncaught e
> xception in thread "IoReceiver - /169.115.199.62:50130"
> org.apache.qpid.transport.SenderClosedException: sender for socket /169.115.199.62:50130
is closed
>         at org.apache.qpid.transport.network.io.IoSender.checkNotAlreadyClosed(IoSender.java:370)
>         at org.apache.qpid.transport.network.io.IoSender.send(IoSender.java:114)
>         at org.apache.qpid.transport.network.io.IoSender.send(IoSender.java:40)
>         at org.apache.qpid.server.protocol.AMQProtocolEngine.writeFrame(AMQProtocolEngine.java:720)
>         at org.apache.qpid.server.protocol.AMQProtocolEngine.exception(AMQProtocolEngine.java:1287)
>         at org.apache.qpid.server.protocol.MultiVersionProtocolEngine.exception(MultiVersionProtocolEngine.java:123)
>         at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:166)
>         at java.lang.Thread.run(Thread.java:722)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message