qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-6470) FieldValue::getFloatingPointValue() converts endian each time it is called
Date Thu, 02 Apr 2015 22:03:57 GMT

    [ https://issues.apache.org/jira/browse/QPID-6470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393550#comment-14393550

Andrew Stitcher commented on QPID-6470:

Can you just clarify - when you say the endian conversion happens "each time" do you mean
that the original bytes are being changed each time to actually screw up the number itself
on platforms with the "wrong" endianness?

[I'm not 100% clear on what convertIfRequired() does]

> FieldValue::getFloatingPointValue() converts endian each time it is called
> --------------------------------------------------------------------------
>                 Key: QPID-6470
>                 URL: https://issues.apache.org/jira/browse/QPID-6470
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client, C++ Clustering
>    Affects Versions: 0.32, 0.33
>         Environment: Windows 7
>            Reporter: Pavel Pokutnev
>            Assignee: Alan Conway
>            Priority: Critical
>              Labels: easyfix, patch
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
> When calling getFloatingPointValue multiple times, the octets are endian-converted each
> Actually we need to make a copy first and then call convertIfRequired().

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message