qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-6470) FieldValue::getFloatingPointValue() converts endian each time it is called
Date Thu, 16 Apr 2015 19:05:00 GMT

    [ https://issues.apache.org/jira/browse/QPID-6470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498525#comment-14498525

ASF subversion and git services commented on QPID-6470:

Commit 1674137 from [~aconway] in branch 'qpid/trunk'
[ https://svn.apache.org/r1674137 ]

QPID-6470: Fix float conversion problems.

Previous code would incorrectly convert between float and int types producing nonsense values,
and would not allow legal conversions between float and double types.

Created FixedWidthIntValue and FixedWidthFloatValue template subclasses to correctly
handle conversions. Enabled FieldValue unit tests for float conversions.

> FieldValue::getFloatingPointValue() converts endian each time it is called
> --------------------------------------------------------------------------
>                 Key: QPID-6470
>                 URL: https://issues.apache.org/jira/browse/QPID-6470
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client, C++ Clustering
>    Affects Versions: 0.32, 0.33
>         Environment: Windows 7
>            Reporter: Pavel Pokutnev
>            Assignee: Alan Conway
>            Priority: Critical
>              Labels: easyfix, patch
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
> When calling getFloatingPointValue multiple times, the octets are endian-converted each
> Actually we need to make a copy first and then call convertIfRequired().

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message