qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim" <g...@redhat.com>
Subject Review Request 33750: Optimisation of map entry deletion
Date Fri, 01 May 2015 09:59:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33750/
-----------------------------------------------------------

Review request for qpid, Alan Conway, Andrew Stitcher, and Rafael Schloming.


Repository: qpid-proton-git


Description
-------

This implements the optimisation suggested by Alan. If the next entry in a chain after the
one being deleted is in the cellar (i.e. is non-addressable), then there is no need to rehahs,
that next entry can simply be copied into the slot being deleted,and the next slot can be
freed.


Diffs
-----

  proton-c/src/object/map.c 2e3b157 

Diff: https://reviews.apache.org/r/33750/diff/


Testing
-------

The second unit test covers this case (as well as some others). My stress testing has also
shown no issue with it.


Thanks,

Gordon Sim


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message