qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPIDJMS-60) using 'nested options' causes issues when adding/removing a URI from the pool object
Date Fri, 29 May 2015 19:14:17 GMT

    [ https://issues.apache.org/jira/browse/QPIDJMS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565240#comment-14565240
] 

ASF subversion and git services commented on QPIDJMS-60:
--------------------------------------------------------

Commit 07d1637d959002cef9c7eb5466f0185618db29bc in qpid-jms's branch refs/heads/master from
[~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=07d1637 ]

https://issues.apache.org/jira/browse/QPIDJMS-58
https://issues.apache.org/jira/browse/QPIDJMS-59
https://issues.apache.org/jira/browse/QPIDJMS-60

URI Pool updated to provide thread safe operations.  Added method
addFirst and used that to ensure that redirect URIs are always used on
the next connect attempt.  Updated the remove method to use the same
logic as add to find the matching URI to remove.

> using 'nested options' causes issues when adding/removing a URI from the pool object
> ------------------------------------------------------------------------------------
>
>                 Key: QPIDJMS-60
>                 URL: https://issues.apache.org/jira/browse/QPIDJMS-60
>             Project: Qpid JMS
>          Issue Type: Bug
>          Components: qpid-jms-client
>    Affects Versions: 0.2.0
>            Reporter: Robbie Gemmell
>            Assignee: Timothy Bish
>
> The failover provider allows adding and removing URIs from the FailoverUriPool object.
This support is used by the Discovery layer to update the applicable URIs. The methods may
not have the intended effect if there are 'nested options' in use however.
> The add method on the pool manipulates the given URI by adding any 'nest options' to
it before insertion. It does this after checking the original URI wasnt already in the pool.
That probably means that if there are nested options then adding the same URI again will insert
a new entry when it wouldnt be expected to.
> The remove method does not manipulate the given URI, so if it doesnt have the nested
options applied to it already then it wont actually get removed from the list.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message