qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Re: Review Request 34999: [amqp1.0] free closed sessions and link
Date Wed, 03 Jun 2015 17:32:21 GMT


> On June 3, 2015, 2:44 p.m., Gordon Sim wrote:
> > Might want to bump up the minimum version of proton supported to 0.7.

Good idea - I'll do that as a separate change just to keep thingy tidy.


- Kenneth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34999/#review86409
-----------------------------------------------------------


On June 3, 2015, 1:05 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34999/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 1:05 p.m.)
> 
> 
> Review request for qpid, Gordon Sim and Ted Ross.
> 
> 
> Bugs: qpid-6563
>     https://issues.apache.org/jira/browse/qpid-6563
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> This patch calls pn_session_free/pn_link_free when both sides of the endpoint have closed.
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/cpp/src/qpid/broker/amqp/Connection.cpp 1682469 
> 
> Diff: https://reviews.apache.org/r/34999/diff/
> 
> 
> Testing
> -------
> 
> Tested this patch against proton versions 0.6 thru 0.9.
> 
> Works for 0.7+.  It appears as if there is a bug in proton 0.6 where proton leaks the
session.  On 0.6, even though qpidd frees all closed sessions, the connection's endpoint list
grows indefinitely with closed session objects.
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message