qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Re: Review Request 35016: Declare static functions static, and change their names to pni_*
Date Thu, 04 Jun 2015 15:39:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35016/#review86630
-----------------------------------------------------------



proton-c/src/buffer.c
<https://reviews.apache.org/r/35016/#comment138678>

    Did you miss the "static" here?


- Andrew Stitcher


On June 3, 2015, 5:49 p.m., michael goulish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35016/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 5:49 p.m.)
> 
> 
> Review request for qpid, Kenneth Giusti and Ted Ross.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> I only changed functions that were not mentioned in public .h files, and that were only
called from within their file.
> 
> A few were not called at all -- and I removed those.
> 
> I made no other changes except declaring functions static, and changing the prefix on
their names to pni_   .
> 
> 
> Diffs
> -----
> 
>   proton-c/src/buffer.c 145292a 
>   proton-c/src/codec/codec.c e8750fe 
>   proton-c/src/codec/decoder.c dbbb13f 
>   proton-c/src/engine/engine-internal.h 2f0cc56 
>   proton-c/src/engine/engine.c 67cc882 
>   proton-c/src/object/list.c 14231f6 
>   proton-c/src/object/map.c c969d24 
>   proton-c/src/parser.c 93b6da4 
>   proton-c/src/scanner.c ef54db4 
>   proton-c/src/transport/transport.c e72875b 
> 
> Diff: https://reviews.apache.org/r/35016/diff/
> 
> 
> Testing
> -------
> 
> It still compiles, and all unit tests still work.
> 
> 
> Thanks,
> 
> michael goulish
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message