qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Re: Review Request 34809: Flavio's patch to allow python to build and install the libqpid-proton library if not present on the system.
Date Thu, 04 Jun 2015 17:26:14 GMT


> On June 4, 2015, 4:33 p.m., Andrew Stitcher wrote:
> > proton-c/CMakeLists.txt, line 546
> > <https://reviews.apache.org/r/34809/diff/6/?file=979165#file979165line546>
> >
> >     I'm not sure this message is necessary - we don't usually comment on things
not found if the case is usual.
> >     
> >     Certainly don't make it a warning as that interupts an interactive cmake session
for no real reason.
> 
> Flavio Percoco wrote:
>     no opinion on this. I'm happy to remove it (although I do appreciate to be notified
when a *test* that was supposed to be excuted is not being executed).

I'd rather you keep it, and simply make it informational rather than a warning.   This message
is issued if the python bindings are being tested, but in the case tox is not available then
we're not only missing the test of the setup.py-installed bindings, but in the future we'll
also be skipping any multi-version python testing (py3 for example).

I'd like to get those devs who are interested in python bindings to install the de facto standard
python testing tools.  Hopefully this little message will nudge some to do so.


- Kenneth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34809/#review86638
-----------------------------------------------------------


On June 4, 2015, 4:09 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34809/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 4:09 p.m.)
> 
> 
> Review request for qpid, Andrew Stitcher, Dominic Evans, Flavio Percoco, Gordon Sim,
and Rafael Schloming.
> 
> 
> Bugs: proton-895
>     https://issues.apache.org/jira/browse/proton-895
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> This change modifies the way setup.py builds and installs the Proton C library should
it not be present on the system.  With this change, setup.py builds the C library directly,
rather than using cmake.  The advantages to this:
> 
> 1) The resultant library is installed in the site-packages directory along with proton.
 This allows non-root users properly install the C librarys when doing a virtualenv or --user
install.
> 2) pip can be used to install/remove the entire proton stack
> 3) only builds the C library - not the whole proton build
> 4) no longer requires cmake, which is not part of a typical python environment
> 
> 
> Diffs
> -----
> 
>   proton-c/CMakeLists.txt 1347f16 
>   proton-c/bindings/python/setup.py 09fa76a 
>   proton-c/bindings/python/setuputils/bundle.py 920744d 
>   proton-c/bindings/python/setuputils/log.py 1e051d4 
>   proton-c/bindings/python/setuputils/misc.py 8978371 
>   proton-c/bindings/python/tox.ini PRE-CREATION 
>   tests/python/proton_tests/common.py 1b8dbdb 
> 
> Diff: https://reviews.apache.org/r/34809/diff/
> 
> 
> Testing
> -------
> 
> All python unit tests pass when run against the bindings and C library installed with
this patch.
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message