qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Re: Review Request 35214: PROTON-902 Remove the dependency on uuid
Date Mon, 08 Jun 2015 18:11:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35214/#review87053
-----------------------------------------------------------



proton-c/bindings/python/setup.py
<https://reviews.apache.org/r/35214/#comment139317>

    We might be better off just checking for the existence of the proper header files here,
since the libuuid library may be installed without them.
    
    From looking at the platform.c file, we could simply map:
    
    if 'uuid/uuid.h' -> USE_UUID_GENERATE
    else if 'uuid.h' -> USE_UUID_CREATE ...
    
    the truely paranoid would check for both headers and the symbol in the library.


- Kenneth Giusti


On June 8, 2015, 3:24 p.m., Flavio Percoco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35214/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 3:24 p.m.)
> 
> 
> Review request for qpid and Rafael Schloming.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> Instead of relying on libuuid for uuid generation, let proton-c have a built-in uuid4
generator as a fallback when no uuid generator is present in the system.
>     
> Eventually, proton-c could simply rely on the built-in generator but lets give this some
time to mature and test.
> 
> 
> Diffs
> -----
> 
>   proton-c/CMakeLists.txt b534e86 
>   proton-c/bindings/python/setup.py b255580 
>   proton-c/src/platform.c 8f8ac5f 
> 
> Diff: https://reviews.apache.org/r/35214/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Flavio Percoco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message