qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Flavio Percoco" <flape...@gmail.com>
Subject Re: Review Request 35252: PROTON-904 Remove the dependency on uuid
Date Tue, 09 Jun 2015 13:59:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35252/#review87175
-----------------------------------------------------------



proton-c/src/platform.c
<https://reviews.apache.org/r/35252/#comment139493>

    I'll move this to `uuid.c` as suggested by Alan in the previous review.


- Flavio Percoco


On June 9, 2015, 1:43 p.m., Flavio Percoco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35252/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 1:43 p.m.)
> 
> 
> Review request for qpid, Chug Rolke, Gordon Sim, and Rafael Schloming.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> Instead of relying on libuuid for uuid generation, let proton-c have a built-in uuid4
generator to do this job.
> 
> 
> Diffs
> -----
> 
>   proton-c/CMakeLists.txt b534e86 
>   proton-c/bindings/python/setup.py 79168d2 
>   proton-c/src/messenger/messenger.c f226f7b 
>   proton-c/src/platform.h 6962493 
>   proton-c/src/platform.c 8f8ac5f 
> 
> Diff: https://reviews.apache.org/r/35252/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Flavio Percoco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message