qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "michael goulish" <mgoul...@redhat.com>
Subject Re: Review Request 33758: do something reasonable with local and remote max channels
Date Wed, 17 Jun 2015 05:45:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33758/
-----------------------------------------------------------

(Updated June 17, 2015, 5:45 a.m.)


Review request for qpid, Kenneth Giusti and Ted Ross.


Changes
-------

added unit test to ensure that channel_max really limits session creation.  This required
a change to swig file to allow pn_session to return NULL.


Repository: qpid-proton-git


Description
-------

PROTON-842 -- channels and sessions


Diffs (updated)
-----

  proton-c/bindings/python/proton/__init__.py 9432bd8 
  proton-c/include/proton/cproton.i ac2b121 
  proton-c/include/proton/transport.h a3ca667 
  proton-c/src/engine/engine-internal.h 4c72310 
  proton-c/src/engine/engine.c c5228a5 
  proton-c/src/transport/transport.c 0e23975 
  tests/python/proton_tests/engine.py 924b3bc 

Diff: https://reviews.apache.org/r/33758/diff/


Testing
-------

I originally did large system-testing using a broker and dispatch routers to get 32K links
through a single connection.

This diff is based on what I did earlier, but improved (i think), and with a couple mistakes
corrected.  Now I am testing only with proton unit tests included with this diff, because
latest dispatch is having an issue with latest proton.


Thanks,

michael goulish


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message