qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Wall (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-6545) malformed cyrillic strings that passed as TextMessage's property
Date Wed, 10 Jun 2015 08:26:02 GMT

    [ https://issues.apache.org/jira/browse/QPID-6545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580214#comment-14580214
] 

Keith Wall commented on QPID-6545:
----------------------------------

A couple of comments on this commit:

# This change will be a breaking change for anyone making direct use of constructors such
as AMQQueue.  These classes have never been considered part of  the public API, but this should
be called out in the release notes.
# The change to the returned types on methods such as AMQBindingURL#getExchangeName()  means
that expressions such as the one  on MessageConverter_0_8_to_1_0.java:118 is now calling String.equals()
with a AMQShortString argument.  This will always be false.   There appear to be many occurrences
on this problem.
# AMQSession_0_10#isQueueBound() redundant tannery logic in return statement.
# org.apache.qpid.client.AMQDestination#createDestination(org.apache.qpid.url.BindingURL)
there is a NPE possibility if exchangeClass is ever null.  This was an existing problem, but
flipping the equals expressions around would eliminate the possibility.


> malformed cyrillic strings that passed as TextMessage's property
> ----------------------------------------------------------------
>
>                 Key: QPID-6545
>                 URL: https://issues.apache.org/jira/browse/QPID-6545
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.32
>         Environment: Windows 8 x84 Russian, RabbitMQ 3.1.5
>            Reporter: Nikita Konev
>            Assignee: Keith Wall
>         Attachments: Runner.java, screenRabbit.png
>
>
> When I attempt pass string that contains cyrillic symbols, it is malformed.
> I see malformed string in Rabbit's web interface and in java code which receives messages
from Rabbit.
> Java src in utf8 Runner.java:38 and rabbit's screen attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message