qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Re: Review Request 36256: Use 4 digit verion numbers
Date Tue, 07 Jul 2015 14:57:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36256/#review90704
-----------------------------------------------------------


I have no objection with moving to a four-component version scheme, however...

I've felt that the version data is too 'spread out' - there's some in setup.py and some in
setuputils/bundle.py.

This makes maintenance brittle - can you move all the version info up into setup.py, in one
place, so we only have one place to update version data?

- Kenneth Giusti


On July 7, 2015, 12:35 p.m., Flavio Percoco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36256/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 12:35 p.m.)
> 
> 
> Review request for qpid and Kenneth Giusti.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> PROTON-895: Use 4 digit verion numbers
> 
> 
> Diffs
> -----
> 
>   proton-c/bindings/python/setup.py 84b5a66dd705763a88d7a19826598fba5117a1b5 
> 
> Diff: https://reviews.apache.org/r/36256/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Flavio Percoco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message