qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Re: Review Request 36315: PROTON-939: allow pn_ssl_set_peer_hostname to override connection's hostname.
Date Wed, 08 Jul 2015 19:53:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36315/#review90977
-----------------------------------------------------------



proton-c/src/transport/transport.c (line 657)
<https://reviews.apache.org/r/36315/#comment144135>

    Just checked the files - no tabs there.
    
    I think it's just reviewboard's way of saying 'these lines have simply been indented'


- Kenneth Giusti


On July 8, 2015, 7:33 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36315/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 7:33 p.m.)
> 
> 
> Review request for qpid and Andrew Stitcher.
> 
> 
> Bugs: proton-939
>     https://issues.apache.org/jira/browse/proton-939
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> Prevents the connection's hostname setting overriding one set via pn_ssl_set_peer_hostname
> 
> 
> Diffs
> -----
> 
>   proton-c/include/proton/ssl.h b250e6a 
>   proton-c/src/transport/transport.c e5e8276 
>   tests/python/proton_tests/ssl.py f3c7f1f 
> 
> Diff: https://reviews.apache.org/r/36315/diff/
> 
> 
> Testing
> -------
> 
> new unit tests added
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message