qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Re: Review Request 36324: NO-JIRA: add python-tox-test to jenkins CI script
Date Thu, 09 Jul 2015 12:39:07 GMT


> On July 8, 2015, 7:08 p.m., Dominic Evans wrote:
> > If tox is already installed this would do a pip upgrade check every run, is that
intentional?
> 
> Kenneth Giusti wrote:
>     Yes, although perhaps a bit heavy handed - we have a requirement for tox versions
>= 1.7, so we have to be sure we're not using some old version of the toolset that's part
of the distro.  In addition, we have to keep an eye on the latest released tox versions, just
to be sure we're compatible. 
>     
>     So I'd like to have Jenkins run under the most recent released version of tox, so
we don't get blind-sided.
> 
> Dominic Evans wrote:
>     I do wonder if it'd be better to at least keep a fixed version number in the jenkins
script so that builds are repeatable and wouldn't get marked as bad if a newer tox version
happened to break the tests.
>     
>     i.e.,  pip install --user -U tox==2.1.1
>     
>     Whilst it does mean you'd have to manually incremement it in the future (if you needed
to) at least that would be captured as an intentional change in the build deltas.

Yeah, thinking this over last night - you've convinced me.

I'm going to take another crack at this anyways.  I've found some issues with running it on
a stripped down ubuntu box.  When I rework it I'll add the specific version checks.


- Kenneth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36324/#review90963
-----------------------------------------------------------


On July 8, 2015, 7:01 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36324/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 7:01 p.m.)
> 
> 
> Review request for qpid and Robbie Gemmell.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> change the script to pull down the latest tox tool and install it locally, then run the
tox tests.
> 
> 
> Diffs
> -----
> 
>   bin/jenkins-proton-c-build.sh 8f0545f 
> 
> Diff: https://reviews.apache.org/r/36324/diff/
> 
> 
> Testing
> -------
> 
> local testing only - not run on Jenkins
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message