qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell" <robbie.gemm...@gmail.com>
Subject Re: Review Request 36509: prevent unwanted finalize for links/sessions
Date Fri, 17 Jul 2015 11:50:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36509/#review92070
-----------------------------------------------------------


Overlooking my nearly non-existent understanding of the proton-c code, this addition to the
previous change seems reasonable to me given the description (from review 35355) of the issue
prompting the original change, i.e only do the inc/decref magic when clearing the modified
flag if the endpoint was freed and isn't referenced as that is when/why the missing action
was described not to have occurred.

- Robbie Gemmell


On July 15, 2015, 3:55 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36509/
> -----------------------------------------------------------
> 
> (Updated July 15, 2015, 3:55 p.m.)
> 
> 
> Review request for qpid and Rafael Schloming.
> 
> 
> Bugs: PROTON-905
>     https://issues.apache.org/jira/browse/PROTON-905
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> The original fix for PROTON-905, https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;a=blobdiff;f=proton-c/src/engine/engine.c;h=fda719a3855e7bda9327148919c154499617c78a;hp=936cf609411d4ed0a8556227bfaf459b8fac753d;hb=653f4e5;hpb=bcfa8d44b8d71edd8c87568ebfd1141be175d054,
results in crashes in proton code during qpid-cpp tests. I believe this is because the finalize
call is triggered too early in some cases. The proposed fix qualifies the previous fix to
only apply in the case it was intended for.
> 
> 
> Diffs
> -----
> 
>   proton-c/src/engine/engine.c fda719a 
> 
> Diff: https://reviews.apache.org/r/36509/diff/
> 
> 
> Testing
> -------
> 
> All proton and qpid-cpp tests pass with this additional fix in place.
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message