qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "michael goulish" <mgoul...@redhat.com>
Subject Re: Review Request 35798: PROTON-919: make the C impl behave same as Java wrt channel_max error
Date Fri, 17 Jul 2015 16:10:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35798/
-----------------------------------------------------------

(Updated July 17, 2015, 4:10 p.m.)


Review request for qpid, Andrew Stitcher and Kenneth Giusti.


Changes
-------

Last time I apparently uploaded a diff here before I finished making changes in the code.
  This diff represents what I actually chacked in.


Repository: qpid-proton-git


Description
-------

Alter C impl to return error code if we attempt to change local channel_max after OPEN frame
has been sent.   Also alter python binding to detect that error code, and throw exception.
 This way, the C and Java versions of one of the test of channel_max functionality have the
same behavior.


Diffs (updated)
-----

  proton-c/bindings/python/proton/__init__.py d5dcceb 
  proton-c/include/proton/error.h 2ed2f31 
  proton-c/include/proton/transport.h 483f5a9 
  proton-c/src/transport/transport.c 7bce3b5 
  tests/python/proton_tests/engine.py c18683f 

Diff: https://reviews.apache.org/r/35798/diff/


Testing
-------

ctest -VV   ---  C and Java

Please note:  This Jira changes the public interface in that it adds #define PN_OK 0 to the
list of possible error return values in error.h


Thanks,

michael goulish


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message