qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Re: Review Request 36744: PROTON-958: Fix the RPATH issue with cached packages
Date Mon, 27 Jul 2015 13:29:02 GMT


> On July 24, 2015, 3:26 p.m., Andrew Stitcher wrote:
> > I'm glad to see some code explanation in here now - I was struggling to understand
what was going on before.
> > 
> > It is still not clear to me, how what is going on here is different to beforethough.

Prior to this patch, when libqpid-proton and headers were not available on the system on which
python-qpid-proton is being installed, the setup.py script would build two shared objects:
libqpid-proton.so and the _cproton.so extension.  It did this by creating an additional extension
for the libqpid-proton.so an install time, one for the actual extension (_cproton.so), and
one for the libqpid-proton.so.

This method is commonly called a "terrible hack".

With this patch, we avoid building two shared objects.  Instead, we incorporate the proton
C files (which were previously built into libqpid-proton.so) directly into the target extension
itself (_cproton.so).


> On July 24, 2015, 3:26 p.m., Andrew Stitcher wrote:
> > proton-c/bindings/python/setup.py, line 439
> > <https://reviews.apache.org/r/36744/diff/1/?file=1020107#file1020107line439>
> >
> >     Do you mean at "install time" rather than "run time".
> >     
> >     [To me run time means when you are actually using proton]

fixed


- Kenneth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36744/#review92918
-----------------------------------------------------------


On July 23, 2015, 8:17 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36744/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 8:17 p.m.)
> 
> 
> Review request for qpid and Flavio Percoco.
> 
> 
> Bugs: proton-958
>     https://issues.apache.org/jira/browse/proton-958
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> See the JIRA.
> 
> 
> Diffs
> -----
> 
>   proton-c/bindings/python/setup.py 1624e5e 
> 
> Diff: https://reviews.apache.org/r/36744/diff/
> 
> 
> Testing
> -------
> 
> Multiple installs, python 2.7 and python 3.4.
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message