qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Moravec (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (QPID-4272) Large amounts of code are duplicated between the SSL and TCP transports
Date Sat, 04 Jul 2015 10:49:04 GMT

     [ https://issues.apache.org/jira/browse/QPID-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Pavel Moravec reopened QPID-4272:
---------------------------------

The duplicate code removal is fine, but it hides error code / description coming from SSL.
Originally:

{code}
cpp/src/qpid/sys/ssl/SslIo.cpp:
QPID_LOG(error, "Error reading socket: " << getErrorString(PR_GetError()));
{code}

now:
{code}
cpp/src/qpid/sys/posix/AsynchIO.cpp:
QPID_LOG(error, "Error reading socket: " << qpid::sys::strError(errno) << "("
<< errno << ")" );
{code}

That means, most of nicely descripted SSL errors like:

{code}
Error reading socket: SSL peer cannot verify your certificate. [-12271]
{code}

are hidden in generous:
{code}
Error reading socket: Success(0)
{code}


Could be these SSL errors put back?

> Large amounts of code are duplicated between the SSL and TCP transports
> -----------------------------------------------------------------------
>
>                 Key: QPID-4272
>                 URL: https://issues.apache.org/jira/browse/QPID-4272
>             Project: Qpid
>          Issue Type: Improvement
>          Components: C++ Broker, C++ Client
>            Reporter: Andrew Stitcher
>            Assignee: Andrew Stitcher
>             Fix For: 0.19
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message